fix #6866 client side cache when running with web sockets #7182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also removed removed unneeded stripHashKey feature from deepEquals()
moellep
commented
Jul 18, 2024
| @@ -1556,14 +1544,155 @@ SIREPO.app.service('validationService', function(utilities) { | |||
|
|
|||
| }); | |||
|
|
|||
| SIREPO.app.factory('srCache', function(appState, $rootScope) { | |||
|
|
|||
There was a problem hiding this comment.
@e-carlin and @robnagler srCache is the client side cache for web sockets, using indexedDB
robnagler
requested changes
Jul 25, 2024
| } | ||
| }; | ||
| c.onerror = () => { | ||
| invokeCallback(callback, null); |
There was a problem hiding this comment.
do we want to log the error even for debugging purposes? Do we want an errorCallback?
There was a problem hiding this comment.
I don't think we want to log every getFrame() call if it fails. Possibly the first failure. The caller can't really do any additional handling other than treating it as a cache-miss.
| }; | ||
| } | ||
|
|
||
| self.clearFrames = (simId, modelName) => { |
There was a problem hiding this comment.
Having frames and generic "object" seems odd to me. This is srFrameCache or something like that.
robnagler
approved these changes
Jul 26, 2024
e-carlin
approved these changes
Jul 29, 2024
- change objectStore() to getObjectStore() and add doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes some improvements for appState.deepCopy() and openmc save calls.